Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Allow the aliases map to map to arbitrary types. #4015

Closed
wants to merge 1 commit into from
Closed

chore: Allow the aliases map to map to arbitrary types. #4015

wants to merge 1 commit into from

Conversation

matts1
Copy link
Contributor

@matts1 matts1 commented Jul 3, 2024

For #3673, we will have aliases such as:

'upload(revision)' = [
  ["fix", "-r", "$revision"],
  ["lint", "-r", "$revision"],
  ["git", "push", "-r", "$revision"],
]

Which will require aliases to map to Vec<Vec<String>>

Checklist

If applicable:

  • [N/A] I have updated CHANGELOG.md
  • [N/A] I have updated the documentation (README.md, docs/, demos/)
  • [N/A] I have updated the config schema (cli/src/config-schema.json)
  • [N/A] I have added tests to cover my changes

@matts1
refactor: Allow the aliases map to map to arbitrary types.
ec0e734 
For jj-vcs#3673, we will have aliases such as:
```toml
'upload(revision)' = [
  ["fix", "-r", "$revision"],
  ["lint", "-r", "$revision"],
  ["git", "push", "-r", "$revision"],
]
```

Which will require aliases to map to `Vec<Vec<String>>`
@matts1 matts1 closed this Jul 3, 2024
@matts1 matts1 deleted the map branch July 3, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matts1